Re: [libvirt] [PATCH] src: Fix checking for clang

2018-03-01 Thread Daniel P . Berrangé
On Thu, Mar 01, 2018 at 05:37:38PM +0100, Andrea Bolognani wrote: > The check was trying to use the shell variable $CC instead of > the make variable $(CC); it also interpreted grep's return code > wrong: 1 means the provided pattern was *not* matched. As a > result, pdwtags was never run, not even

[libvirt] [PATCH] src: Fix checking for clang

2018-03-01 Thread Andrea Bolognani
The check was trying to use the shell variable $CC instead of the make variable $(CC); it also interpreted grep's return code wrong: 1 means the provided pattern was *not* matched. As a result, pdwtags was never run, not even when building with gcc. Signed-off-by: Andrea Bolognani --- src/Makefi