Re: [libvirt] [PATCH] storage: Fix a NULL ptr dereference in virStorageBackendCreateQemuImg

2016-08-04 Thread Andrea Bolognani
On Thu, 2016-08-04 at 07:46 -0400, John Ferlan wrote: > > Should we check to make sure that vol and vol->target are > > non-NULL as well? >  > Well by this point vol would have already been dereferenced by the > callers virStorageBackendGetBuildVolFromFunction or > _virStorageBackendFileSystemVolBu

Re: [libvirt] [PATCH] storage: Fix a NULL ptr dereference in virStorageBackendCreateQemuImg

2016-08-04 Thread John Ferlan
On 08/04/2016 04:48 AM, Andrea Bolognani wrote: > On Wed, 2016-08-03 at 12:27 +0200, Erik Skultety wrote: >> There was a missing check for vol->target.encryption being NULL >> at one particular place (modified by commit a48c71411) which caused a crash >> when user attempted to create a raw volume

Re: [libvirt] [PATCH] storage: Fix a NULL ptr dereference in virStorageBackendCreateQemuImg

2016-08-04 Thread Andrea Bolognani
On Wed, 2016-08-03 at 12:27 +0200, Erik Skultety wrote: > There was a missing check for vol->target.encryption being NULL > at one particular place (modified by commit a48c71411) which caused a crash > when user attempted to create a raw volume using a non-raw file volume as > source. >  > Resolves

[libvirt] [PATCH] storage: Fix a NULL ptr dereference in virStorageBackendCreateQemuImg

2016-08-03 Thread Erik Skultety
There was a missing check for vol->target.encryption being NULL at one particular place (modified by commit a48c71411) which caused a crash when user attempted to create a raw volume using a non-raw file volume as source. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1363636 Signed-off-by