Re: [libvirt] [PATCH] storage: avoid null deref and leak on failure

2011-05-04 Thread Eric Blake
On 05/03/2011 11:18 PM, Laine Stump wrote: > On 05/03/2011 01:58 PM, Eric Blake wrote: >> Detected by clang. NULL deref added in commit 343a27a (Mar 11), >> but leak of voldef present since commit 2cd9b2d (Apr 09). >> >> * src/storage/storage_driver.c (storageVolumeCreateXML): Don't >> leak voldef

Re: [libvirt] [PATCH] storage: avoid null deref and leak on failure

2011-05-03 Thread Laine Stump
On 05/03/2011 01:58 PM, Eric Blake wrote: Detected by clang. NULL deref added in commit 343a27a (Mar 11), but leak of voldef present since commit 2cd9b2d (Apr 09). * src/storage/storage_driver.c (storageVolumeCreateXML): Don't leak voldef or dereference null volobj. --- src/storage/storage_dr

[libvirt] [PATCH] storage: avoid null deref and leak on failure

2011-05-03 Thread Eric Blake
Detected by clang. NULL deref added in commit 343a27a (Mar 11), but leak of voldef present since commit 2cd9b2d (Apr 09). * src/storage/storage_driver.c (storageVolumeCreateXML): Don't leak voldef or dereference null volobj. --- src/storage/storage_driver.c |4 +++- 1 files changed, 3 insert