Re: [libvirt] [PATCH] storage: prefer using newDef to save configfile

2018-07-11 Thread Michal Privoznik
On 07/11/2018 03:51 AM, Shichangkuo wrote: > > >> -Original Message- >> From: Michal Privoznik [mailto:mpriv...@redhat.com] >> Sent: Tuesday, July 10, 2018 9:27 PM >> To: shichangkuo (Cloud); 'libvir-list@redhat.com'; 'jfer...@redhat.com' >> Subject: R

Re: [libvirt] [PATCH] storage: prefer using newDef to save configfile

2018-07-10 Thread Shichangkuo
> -Original Message- > From: Michal Privoznik [mailto:mpriv...@redhat.com] > Sent: Tuesday, July 10, 2018 9:27 PM > To: shichangkuo (Cloud); 'libvir-list@redhat.com'; 'jfer...@redhat.com' > Subject: Re: [libvirt] [PATCH] storage: prefer using newDef to save configfile &g

Re: [libvirt] [PATCH] storage: prefer using newDef to save configfile

2018-07-10 Thread Michal Privoznik
On 07/10/2018 09:15 AM, Shichangkuo wrote: > When re-defining an active storage pool, the configfile has not changed. This > issue was introduced by bfcd8fc9, > storage: Use virStoragePoolObjGetDef accessor for driver. So we prefer using > newDef to save configfile. > > Signed-off-by: Changkuo

[libvirt] [PATCH] storage: prefer using newDef to save configfile

2018-07-10 Thread Shichangkuo
When re-defining an active storage pool, the configfile has not changed. This issue was introduced by bfcd8fc9, storage: Use virStoragePoolObjGetDef accessor for driver. So we prefer using newDef to save configfile. Signed-off-by: Changkuo Shi --- src/storage/storage_driver.c |6 -- 1