Re: [libvirt] [PATCH] storage: skip selinux cleanup when fd not available

2013-11-27 Thread Eric Blake
On 11/26/2013 11:43 PM, Osier Yang wrote: On 27/11/13 12:00, Eric Blake wrote: When attempting to backport gluster pools to an older version where there is no VIR_STRDUP, I got a crash from calling strdup(,NULL). Rather than relying on the current else branch safely doing nothing when there

[libvirt] [PATCH] storage: skip selinux cleanup when fd not available

2013-11-26 Thread Eric Blake
When attempting to backport gluster pools to an older version where there is no VIR_STRDUP, I got a crash from calling strdup(,NULL). Rather than relying on the current else branch safely doing nothing when there is no fd, it is easier to just skip it. While at it, there's no need to explicitly

Re: [libvirt] [PATCH] storage: skip selinux cleanup when fd not available

2013-11-26 Thread Osier Yang
On 27/11/13 12:00, Eric Blake wrote: When attempting to backport gluster pools to an older version where there is no VIR_STRDUP, I got a crash from calling strdup(,NULL). Rather than relying on the current else branch safely doing nothing when there is no fd, it is easier to just skip it. While