Re: [libvirt] [PATCH] systemd: fix build without dbus

2015-01-19 Thread Martin Kletzander
On Mon, Jan 19, 2015 at 02:13:12PM +0100, Martin Kletzander wrote: On Mon, Jan 19, 2015 at 12:34:52PM +, Daniel P. Berrange wrote: The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants to pass a non-NULL value for this, it immediately makes the calling

Re: [libvirt] [PATCH] systemd: fix build without dbus

2015-01-19 Thread Daniel P. Berrange
On Mon, Jan 19, 2015 at 02:13:12PM +0100, Martin Kletzander wrote: On Mon, Jan 19, 2015 at 12:34:52PM +, Daniel P. Berrange wrote: The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants to pass a non-NULL value for this, it immediately makes the calling

Re: [libvirt] [PATCH] systemd: fix build without dbus

2015-01-19 Thread Daniel P. Berrange
On Mon, Jan 19, 2015 at 02:24:34PM +0100, Martin Kletzander wrote: On Mon, Jan 19, 2015 at 02:13:12PM +0100, Martin Kletzander wrote: On Mon, Jan 19, 2015 at 12:34:52PM +, Daniel P. Berrange wrote: The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants

Re: [libvirt] [PATCH] systemd: fix build without dbus

2015-01-19 Thread Martin Kletzander
On Mon, Jan 19, 2015 at 01:28:15PM +, Daniel P. Berrange wrote: On Mon, Jan 19, 2015 at 02:13:12PM +0100, Martin Kletzander wrote: On Mon, Jan 19, 2015 at 12:34:52PM +, Daniel P. Berrange wrote: The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants

Re: [libvirt] [PATCH] systemd: fix build without dbus

2015-01-19 Thread Daniel P. Berrange
On Mon, Jan 19, 2015 at 02:50:19PM +0100, Martin Kletzander wrote: On Mon, Jan 19, 2015 at 01:28:15PM +, Daniel P. Berrange wrote: On Mon, Jan 19, 2015 at 02:13:12PM +0100, Martin Kletzander wrote: On Mon, Jan 19, 2015 at 12:34:52PM +, Daniel P. Berrange wrote: The virDBusMethodCall

Re: [libvirt] [PATCH] systemd: fix build without dbus

2015-01-19 Thread Martin Kletzander
On Mon, Jan 19, 2015 at 12:34:52PM +, Daniel P. Berrange wrote: The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants to pass a non-NULL value for this, it immediately makes the calling code require DBus at build time. This has led to breakage of non-DBus

[libvirt] [PATCH] systemd: fix build without dbus

2015-01-19 Thread Daniel P. Berrange
The virDBusMethodCall method has a DBusError as one of its parameters. If the caller wants to pass a non-NULL value for this, it immediately makes the calling code require DBus at build time. This has led to breakage of non-DBus builds several times. It is desirable that only the virdbus.c file