Re: [libvirt] [PATCH] test: Drop a few unnecessary elements added by virt-install

2019-03-13 Thread Daniel P . Berrangé
On Wed, Mar 13, 2019 at 02:29:08PM +0100, Erik Skultety wrote: > On Wed, Mar 13, 2019 at 10:04:27AM +0100, Andrea Bolognani wrote: > > On Wed, 2019-03-13 at 09:42 +0100, Erik Skultety wrote: > > > The elements were added in commit 4d7ea75e and > > > apparently generated by virt-install, but since

Re: [libvirt] [PATCH] test: Drop a few unnecessary elements added by virt-install

2019-03-13 Thread Erik Skultety
On Wed, Mar 13, 2019 at 10:04:27AM +0100, Andrea Bolognani wrote: > On Wed, 2019-03-13 at 09:42 +0100, Erik Skultety wrote: > > The elements were added in commit 4d7ea75e and > > apparently generated by virt-install, but since the @path attribute > > is missing, the element will never be

Re: [libvirt] [PATCH] test: Drop a few unnecessary elements added by virt-install

2019-03-13 Thread Andrea Bolognani
On Wed, 2019-03-13 at 09:42 +0100, Erik Skultety wrote: > The elements were added in commit 4d7ea75e and > apparently generated by virt-install, but since the @path attribute > is missing, the element will never be formatted back to the XML which the > libvirt-go-xml-check expects, so it fails. >

[libvirt] [PATCH] test: Drop a few unnecessary elements added by virt-install

2019-03-13 Thread Erik Skultety
The elements were added in commit 4d7ea75e and apparently generated by virt-install, but since the @path attribute is missing, the element will never be formatted back to the XML which the libvirt-go-xml-check expects, so it fails. The lack of the @path attribute is not a problem in general,