Re: [libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal

2019-06-19 Thread Erik Skultety
On Tue, Jun 04, 2019 at 03:17:43PM +0200, Ilias Stamatis wrote: > Only succeed when @pid_value is 1, since according to the docs this is > the minimum requirement for any driver to implement this API. > > >From man 2 kill: > The only signals that can be sent to process ID 1, the init process, are >

Re: [libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal

2019-06-19 Thread Erik Skultety
On Tue, Jun 04, 2019 at 03:17:43PM +0200, Ilias Stamatis wrote: > Only succeed when @pid_value is 1, since according to the docs this is > the minimum requirement for any driver to implement this API. > > >From man 2 kill: > The only signals that can be sent to process ID 1, the init process, are >

Re: [libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal

2019-06-19 Thread Erik Skultety
On Tue, Jun 18, 2019 at 03:43:08PM +0200, Pavel Hrdina wrote: > On Mon, Jun 17, 2019 at 10:14:37PM +0200, Ilias Stamatis wrote: > > On Mon, Jun 17, 2019 at 9:52 AM Erik Skultety wrote: > > > > > > On Fri, Jun 14, 2019 at 12:59:11PM +0200, Ilias Stamatis wrote: > > > > On Fri, Jun 14, 2019 at 10:07

Re: [libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal

2019-06-18 Thread Pavel Hrdina
On Mon, Jun 17, 2019 at 10:14:37PM +0200, Ilias Stamatis wrote: > On Mon, Jun 17, 2019 at 9:52 AM Erik Skultety wrote: > > > > On Fri, Jun 14, 2019 at 12:59:11PM +0200, Ilias Stamatis wrote: > > > On Fri, Jun 14, 2019 at 10:07 AM Erik Skultety > > > wrote: > > > > > > > > On Thu, Jun 13, 2019 at

Re: [libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal

2019-06-17 Thread Ilias Stamatis
On Mon, Jun 17, 2019 at 9:52 AM Erik Skultety wrote: > > On Fri, Jun 14, 2019 at 12:59:11PM +0200, Ilias Stamatis wrote: > > On Fri, Jun 14, 2019 at 10:07 AM Erik Skultety wrote: > > > > > > On Thu, Jun 13, 2019 at 02:20:22PM +0200, Ilias Stamatis wrote: > > > > On Thu, Jun 13, 2019 at 10:20 AM E

Re: [libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal

2019-06-17 Thread Erik Skultety
On Fri, Jun 14, 2019 at 12:59:11PM +0200, Ilias Stamatis wrote: > On Fri, Jun 14, 2019 at 10:07 AM Erik Skultety wrote: > > > > On Thu, Jun 13, 2019 at 02:20:22PM +0200, Ilias Stamatis wrote: > > > On Thu, Jun 13, 2019 at 10:20 AM Erik Skultety > > > wrote: > > > > > > > > On Tue, Jun 04, 2019 a

Re: [libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal

2019-06-14 Thread Ilias Stamatis
On Fri, Jun 14, 2019 at 10:07 AM Erik Skultety wrote: > > On Thu, Jun 13, 2019 at 02:20:22PM +0200, Ilias Stamatis wrote: > > On Thu, Jun 13, 2019 at 10:20 AM Erik Skultety wrote: > > > > > > On Tue, Jun 04, 2019 at 03:17:43PM +0200, Ilias Stamatis wrote: > > > > Only succeed when @pid_value is 1

Re: [libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal

2019-06-14 Thread Erik Skultety
On Thu, Jun 13, 2019 at 02:20:22PM +0200, Ilias Stamatis wrote: > On Thu, Jun 13, 2019 at 10:20 AM Erik Skultety wrote: > > > > On Tue, Jun 04, 2019 at 03:17:43PM +0200, Ilias Stamatis wrote: > > > Only succeed when @pid_value is 1, since according to the docs this is > > > > Why do we need to res

Re: [libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal

2019-06-13 Thread Ilias Stamatis
On Thu, Jun 13, 2019 at 10:20 AM Erik Skultety wrote: > > On Tue, Jun 04, 2019 at 03:17:43PM +0200, Ilias Stamatis wrote: > > Only succeed when @pid_value is 1, since according to the docs this is > > Why do we need to restrict ourselves for @pid 1 in the test driver? This > restriction exists in

Re: [libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal

2019-06-13 Thread Erik Skultety
On Tue, Jun 04, 2019 at 03:17:43PM +0200, Ilias Stamatis wrote: > Only succeed when @pid_value is 1, since according to the docs this is Why do we need to restrict ourselves for @pid 1 in the test driver? This restriction exists in LXC for a reason, but why in test driver? a) it's only a check wit

[libvirt] [PATCH] test_driver: implement virDomainSendProcessSignal

2019-06-04 Thread Ilias Stamatis
Only succeed when @pid_value is 1, since according to the docs this is the minimum requirement for any driver to implement this API. >From man 2 kill: The only signals that can be sent to process ID 1, the init process, are those for which init has explicitly installed signal handlers. Regarding