Re: [libvirt] [PATCH] tests: dynamically replace dnsmasq path

2012-01-31 Thread Philipp Hahn
Hello Eric, Am Montag 30 Januar 2012 20:18:15 schrieb Eric Blake: +if (diff 0) { +tmp = realloc((void *)*buf, new_len); We should not be using realloc in this file, but should be using VIR_RESIZE_N or similar. Okay, makes the code even more readable. +

Re: [libvirt] [PATCH] tests: dynamically replace dnsmasq path

2012-01-31 Thread Eric Blake
On 01/31/2012 07:58 AM, Philipp Hahn wrote: Hello Eric, Am Montag 30 Januar 2012 20:18:15 schrieb Eric Blake: +if (diff 0) { +tmp = realloc((void *)*buf, new_len); We should not be using realloc in this file, but should be using VIR_RESIZE_N or similar. Okay, makes

[libvirt] [PATCH] tests: dynamically replace dnsmasq path

2012-01-30 Thread Philipp Hahn
The path to the dnsmasq binary can be configured while in the test data the path is hard-coded to /usr/bin/. This break the test suite if a the binary is located in a different location, like /usr/local/sbin/. Replace the hard coded path in the test data by a token, which is dynamically replaced

Re: [libvirt] [PATCH] tests: dynamically replace dnsmasq path

2012-01-30 Thread Eric Blake
On 01/30/2012 10:13 AM, Philipp Hahn wrote: The path to the dnsmasq binary can be configured while in the test data the path is hard-coded to /usr/bin/. This break the test suite if a the binary is located in a different location, like /usr/local/sbin/. Replace the hard coded path in the