Re: [libvirt] [PATCH] tests: fix mocking of stat() / lstat() functions

2019-04-05 Thread Jim Fehlig
On 4/2/19 3:42 AM, Michal Privoznik wrote: On 4/2/19 10:58 AM, Daniel P. Berrangé wrote: On Mon, Apr 01, 2019 at 06:03:29PM +0100, Daniel P. Berrangé wrote: Quite a few of the tests have a need to mock the stat() / lstat() functions and they are taking somewhat different & inconsistent

Re: [libvirt] [PATCH] tests: fix mocking of stat() / lstat() functions

2019-04-02 Thread Michal Privoznik
On 4/2/19 10:58 AM, Daniel P. Berrangé wrote: > On Mon, Apr 01, 2019 at 06:03:29PM +0100, Daniel P. Berrangé wrote: >> Quite a few of the tests have a need to mock the stat() / lstat() >> functions and they are taking somewhat different & inconsistent >> approaches none of which are actually fully

Re: [libvirt] [PATCH] tests: fix mocking of stat() / lstat() functions

2019-04-02 Thread Daniel P . Berrangé
On Mon, Apr 01, 2019 at 06:03:29PM +0100, Daniel P. Berrangé wrote: > Quite a few of the tests have a need to mock the stat() / lstat() > functions and they are taking somewhat different & inconsistent > approaches none of which are actually fully correct. This is shown > by fact that 'make check'

[libvirt] [PATCH] tests: fix mocking of stat() / lstat() functions

2019-04-01 Thread Daniel P . Berrangé
Quite a few of the tests have a need to mock the stat() / lstat() functions and they are taking somewhat different & inconsistent approaches none of which are actually fully correct. This is shown by fact that 'make check' fails on 32-bit hosts. Investigation revealed that the code was calling