Re: [libvirt] [PATCH] tests: reintroduce tests for libxl's legacy nested setting

2018-10-01 Thread Jim Fehlig
On 10/1/18 2:35 AM, Erik Skultety wrote: On Mon, Oct 01, 2018 at 08:04:57AM +0200, Erik Skultety wrote: On Thu, Sep 27, 2018 at 08:25:53AM -0600, Jim Fehlig wrote: On 9/27/18 3:29 AM, Erik Skultety wrote: On Wed, Sep 26, 2018 at 11:31:19AM -0600, Jim Fehlig wrote: The preferred location for s

Re: [libvirt] [PATCH] tests: reintroduce tests for libxl's legacy nested setting

2018-10-01 Thread Erik Skultety
On Mon, Oct 01, 2018 at 08:04:57AM +0200, Erik Skultety wrote: > On Thu, Sep 27, 2018 at 08:25:53AM -0600, Jim Fehlig wrote: > > On 9/27/18 3:29 AM, Erik Skultety wrote: > > > On Wed, Sep 26, 2018 at 11:31:19AM -0600, Jim Fehlig wrote: > > > > The preferred location for setting the nested CPU flag

Re: [libvirt] [PATCH] tests: reintroduce tests for libxl's legacy nested setting

2018-09-30 Thread Erik Skultety
On Thu, Sep 27, 2018 at 08:25:53AM -0600, Jim Fehlig wrote: > On 9/27/18 3:29 AM, Erik Skultety wrote: > > On Wed, Sep 26, 2018 at 11:31:19AM -0600, Jim Fehlig wrote: > > > The preferred location for setting the nested CPU flag changed in > > > Xen 4.10 and is advertised via the LIBXL_HAVE_BUILDINF

Re: [libvirt] [PATCH] tests: reintroduce tests for libxl's legacy nested setting

2018-09-27 Thread Jim Fehlig
On 9/27/18 3:29 AM, Erik Skultety wrote: On Wed, Sep 26, 2018 at 11:31:19AM -0600, Jim Fehlig wrote: The preferred location for setting the nested CPU flag changed in Xen 4.10 and is advertised via the LIBXL_HAVE_BUILDINFO_NESTED_HVM define. Commit 95d19cd0 changed libxl to use the new preferre

Re: [libvirt] [PATCH] tests: reintroduce tests for libxl's legacy nested setting

2018-09-27 Thread Erik Skultety
On Wed, Sep 26, 2018 at 11:31:19AM -0600, Jim Fehlig wrote: > The preferred location for setting the nested CPU flag changed in > Xen 4.10 and is advertised via the LIBXL_HAVE_BUILDINFO_NESTED_HVM > define. Commit 95d19cd0 changed libxl to use the new preferred > location but unconditionally chang

[libvirt] [PATCH] tests: reintroduce tests for libxl's legacy nested setting

2018-09-26 Thread Jim Fehlig
The preferred location for setting the nested CPU flag changed in Xen 4.10 and is advertised via the LIBXL_HAVE_BUILDINFO_NESTED_HVM define. Commit 95d19cd0 changed libxl to use the new preferred location but unconditionally changed the tests, causing 'make check' failures against Xen < 4.10 that