Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Daniel P . Berrangé
On Tue, Sep 04, 2018 at 02:10:56PM +0200, Andrea Bolognani wrote: > On Tue, 2018-09-04 at 13:05 +0100, Daniel P. Berrangé wrote: > > > > Pushed as a build fix for platforms without JSON parser installed > > > > > > Which platforms? All machines in our CI environments should have > > > yajl install

Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Ján Tomko
On Tue, Sep 04, 2018 at 02:00:21PM +0200, Andrea Bolognani wrote: On Tue, 2018-09-04 at 12:01 +0100, Daniel P. Berrangé wrote: If no JSON parser is available qemublocktest fails, so skip its execution. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix for platforms without JSON pars

Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Andrea Bolognani
On Tue, 2018-09-04 at 13:05 +0100, Daniel P. Berrangé wrote: > > > Pushed as a build fix for platforms without JSON parser installed > > > > Which platforms? All machines in our CI environments should have > > yajl installed. > > It wasn't CI - it was my own FreeBSD machine without yajl I see so

Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Daniel P . Berrangé
On Tue, Sep 04, 2018 at 02:00:21PM +0200, Andrea Bolognani wrote: > On Tue, 2018-09-04 at 12:01 +0100, Daniel P. Berrangé wrote: > > If no JSON parser is available qemublocktest fails, so skip its execution. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > > > Pushed as a build fix for plat

Re: [libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Andrea Bolognani
On Tue, 2018-09-04 at 12:01 +0100, Daniel P. Berrangé wrote: > If no JSON parser is available qemublocktest fails, so skip its execution. > > Signed-off-by: Daniel P. Berrangé > --- > > Pushed as a build fix for platforms without JSON parser installed Which platforms? All machines in our CI env

[libvirt] [PATCH] tests: skip qemublocktest if building without YAJL

2018-09-04 Thread Daniel P . Berrangé
If no JSON parser is available qemublocktest fails, so skip its execution. Signed-off-by: Daniel P. Berrangé --- Pushed as a build fix for platforms without JSON parser installed tests/qemublocktest.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-)