Re: [libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

2017-05-11 Thread Daniel P. Berrange
On Thu, May 11, 2017 at 03:40:37PM +0200, Martin Kletzander wrote: > On Thu, May 11, 2017 at 02:16:11PM +0100, Daniel P. Berrange wrote: > > On Thu, May 11, 2017 at 03:13:03PM +0200, Martin Kletzander wrote: > > > On Thu, May 11, 2017 at 11:46:01AM +0100, Daniel P. Berrange wrote: > > > > The Win32

Re: [libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

2017-05-11 Thread Martin Kletzander
On Thu, May 11, 2017 at 02:16:11PM +0100, Daniel P. Berrange wrote: On Thu, May 11, 2017 at 03:13:03PM +0200, Martin Kletzander wrote: On Thu, May 11, 2017 at 11:46:01AM +0100, Daniel P. Berrange wrote: > The Win32 platform can not do link time overrides in the same way > that we can on POSIX /

Re: [libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

2017-05-11 Thread Daniel P. Berrange
On Thu, May 11, 2017 at 03:13:03PM +0200, Martin Kletzander wrote: > On Thu, May 11, 2017 at 11:46:01AM +0100, Daniel P. Berrange wrote: > > The Win32 platform can not do link time overrides in the same way > > that we can on POSIX / ELF based platforms, so we cannot build > > the virfilewrapper.c

Re: [libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

2017-05-11 Thread Martin Kletzander
On Thu, May 11, 2017 at 11:46:01AM +0100, Daniel P. Berrange wrote: The Win32 platform can not do link time overrides in the same way that we can on POSIX / ELF based platforms, so we cannot build the virfilewrapper.c code reliably. Just stub it out on Win32 so it is a no-op. Tests that use this

[libvirt] [PATCH] tests: stub out virfilewrapper.c on Win32

2017-05-11 Thread Daniel P. Berrange
The Win32 platform can not do link time overrides in the same way that we can on POSIX / ELF based platforms, so we cannot build the virfilewrapper.c code reliably. Just stub it out on Win32 so it is a no-op. Tests that use this file are already written to skip on Win32. Signed-off-by: Daniel P. B