Re: [libvirt] [PATCH] tests: teach syntax-check that virDomainDefFree has free-like semantics

2010-03-26 Thread Jim Meyering
Eric Blake wrote: On 03/25/2010 02:56 PM, Jim Meyering wrote: Thanks for highlighting that. Our syntax-check rule should have caught it. With the following change, it does, along with one other: src/conf/domain_conf.c: if (domain-newDef)

[libvirt] [PATCH] tests: teach syntax-check that virDomainDefFree has free-like semantics

2010-03-25 Thread Jim Meyering
Eric Blake wrote: On 03/24/2010 08:52 AM, Jiri Denemark wrote: ... virDomainObjPtr virDomainAssignDef(virCapsPtr caps, ... } else { -if (domain-newDef) -virDomainDefFree(domain-newDef); +virDomainDefFree(domain-newDef); And nice removal

Re: [libvirt] [PATCH] tests: teach syntax-check that virDomainDefFree has free-like semantics

2010-03-25 Thread Eric Blake
On 03/25/2010 02:56 PM, Jim Meyering wrote: Thanks for highlighting that. Our syntax-check rule should have caught it. With the following change, it does, along with one other: src/conf/domain_conf.c: if (domain-newDef) virDomainDefFree(domain-newDef)