On Wed, 2019-02-20 at 07:33 -0500, John Ferlan wrote:
> On 2/20/19 2:37 AM, Michal Privoznik wrote:
> > On 2/19/19 9:19 PM, John Ferlan wrote:
> > > Assuming extraction (sigh) of the VIR_AUTOFREE,
> >
> > While I'd definitely want this to be split into two patches if it was
> > fixing something
On 2/20/19 1:56 PM, Andrea Bolognani wrote:
On Wed, 2019-02-20 at 07:33 -0500, John Ferlan wrote:
On 2/20/19 2:37 AM, Michal Privoznik wrote:
On 2/19/19 9:19 PM, John Ferlan wrote:
Assuming extraction (sigh) of the VIR_AUTOFREE,
While I'd definitely want this to be split into two patches if
On 2/19/19 9:19 PM, John Ferlan wrote:
Assuming extraction (sigh) of the VIR_AUTOFREE,
Reviewed-by: John Ferlan
While I'd definitely want this to be split into two patches if it was
fixing something under src/, but this is under tests/ and therefore I
did not bother. The reason for
On Wed, 2019-02-20 at 14:06 +0100, Michal Privoznik wrote:
> On 2/20/19 1:56 PM, Andrea Bolognani wrote:
> > There is barely ever a reason *not* to split changes into smaller,
> > independent units; having to write "at the same time" in the commit
> > message should be your hint that you're doing
On 2/20/19 2:37 AM, Michal Privoznik wrote:
> On 2/19/19 9:19 PM, John Ferlan wrote:
>> Assuming extraction (sigh) of the VIR_AUTOFREE,
>>
>> Reviewed-by: John Ferlan
>>
>
> While I'd definitely want this to be split into two patches if it was
> fixing something under src/, but this is under
On 2/19/19 12:22 PM, Michal Privoznik wrote:
> Currently, some arguments are called strcontent and strsrc, or
> content and src or some other combination. This makes it
> impossible to see at the first glance what argument is supposed
> to represent 'expected' value and which one represents
Currently, some arguments are called strcontent and strsrc, or
content and src or some other combination. This makes it
impossible to see at the first glance what argument is supposed
to represent 'expected' value and which one represents 'actual'
value. Rename the arguments to make it obvious.
