Re: [libvirt] [PATCH] tools: fix variable scope in in check_guests_shutdown

2018-03-23 Thread Christian Ehrhardt
On Thu, Mar 22, 2018 at 5:26 PM, Martin Kletzander wrote: > On Mon, Mar 19, 2018 at 12:44:31PM +0100, Christian Ehrhardt wrote: > >> libvirt-guests.sh when run with more active guests than requested to >> shut down in parallel will run until it times out only shutting down

Re: [libvirt] [PATCH] tools: fix variable scope in in check_guests_shutdown

2018-03-22 Thread Martin Kletzander
On Mon, Mar 19, 2018 at 12:44:31PM +0100, Christian Ehrhardt wrote: libvirt-guests.sh when run with more active guests than requested to shut down in parallel will run until it times out only shutting down the first set of guests. This patch fixes parallel shutdown by fixing a variable scope

Re: [libvirt] [PATCH] tools: fix variable scope in in check_guests_shutdown

2018-03-19 Thread Michal Privoznik
On 03/19/2018 12:44 PM, Christian Ehrhardt wrote: > libvirt-guests.sh when run with more active guests than requested to > shut down in parallel will run until it times out only shutting down > the first set of guests. > > This patch fixes parallel shutdown by fixing a variable scope issue >

[libvirt] [PATCH] tools: fix variable scope in in check_guests_shutdown

2018-03-19 Thread Christian Ehrhardt
libvirt-guests.sh when run with more active guests than requested to shut down in parallel will run until it times out only shutting down the first set of guests. This patch fixes parallel shutdown by fixing a variable scope issue where check_guests_shutdown unintentionally reset $guests which