Re: [libvirt] [PATCH] tools: relax x509 Subject regexes to allow numbers and more

2018-12-11 Thread Daniel P . Berrangé
On Tue, Dec 11, 2018 at 10:04:34AM +0100, Kashyap Chamarthy wrote: > On Mon, Dec 10, 2018 at 04:53:27PM +, Daniel P. Berrangé wrote: > > The virt-pki-validate tool is extracting components in the x509 > > certificate Subject field. Unfortunately the regex it is is using is far > > too strict,

Re: [libvirt] [PATCH] tools: relax x509 Subject regexes to allow numbers and more

2018-12-11 Thread Kashyap Chamarthy
On Mon, Dec 10, 2018 at 04:53:27PM +, Daniel P. Berrangé wrote: > The virt-pki-validate tool is extracting components in the x509 > certificate Subject field. Unfortunately the regex it is is using is far > too strict, and so truncating valid data. It needs to consider ',' as a > field

Re: [libvirt] [PATCH] tools: relax x509 Subject regexes to allow numbers and more

2018-12-11 Thread Kashyap Chamarthy
On Mon, Dec 10, 2018 at 04:53:27PM +, Daniel P. Berrangé wrote: > The virt-pki-validate tool is extracting components in the x509 > certificate Subject field. Unfortunately the regex it is is using is far > too strict, and so truncating valid data. It needs to consider ',' as a > field

[libvirt] [PATCH] tools: relax x509 Subject regexes to allow numbers and more

2018-12-10 Thread Daniel P . Berrangé
The virt-pki-validate tool is extracting components in the x509 certificate Subject field. Unfortunately the regex it is is using is far too strict, and so truncating valid data. It needs to consider ',' as a field separator, and if that's not there take all data until the EOL. With the broken