Re: [libvirt] [PATCH] udev: fix crash in libudev logging

2013-06-13 Thread Ján Tomko
On 06/10/2013 05:05 PM, Guan Nan Ren wrote: I have been trying to fix this bug these days, but I failed to find a good way to bypass the warning you mentioned above caused by a gcc bug: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=28492 I can not find a better way than the casting in your

Re: [libvirt] [PATCH] udev: fix crash in libudev logging

2013-06-10 Thread Guan Nan Ren
- Original Message - From: Ján Tomko jto...@redhat.com To: libvir-list@redhat.com Sent: Friday, June 7, 2013 7:20:10 AM Subject: [libvirt] [PATCH] udev: fix crash in libudev logging VIR_ERROR_INT calls virLogMessage(..., const char *fmt, ...). Call virLogVMessage(..., const char *fmt

[libvirt] [PATCH] udev: fix crash in libudev logging

2013-06-07 Thread Ján Tomko
VIR_ERROR_INT calls virLogMessage(..., const char *fmt, ...). Call virLogVMessage(..., const char *fmt, va_list list) instead, since libudev called us with a va_list object, not a list of arguments. https://bugzilla.redhat.com/show_bug.cgi?id=969152 --- Without the cast, I was getting: