Re: [libvirt] [PATCH] util, remote: Fixing the sending of stream when length is defined.

2018-03-12 Thread Michal Privoznik
On 03/04/2018 08:24 PM, Julio Faracco wrote: > When a length of a file is defined, the responsible thread to send > stream is finishing inappropriately. It is happening because there is > wrong conditional which compares an offset with the length and because > of that the code throws ENOSPC error.

Re: [libvirt] [PATCH] util, remote: Fixing the sending of stream when length is defined.

2018-03-05 Thread Peter Krempa
On Sun, Mar 04, 2018 at 16:24:21 -0300, Julio Faracco wrote: > When a length of a file is defined, the responsible thread to send > stream is finishing inappropriately. It is happening because there is > wrong conditional which compares an offset with the length and because > of that the code

Re: [libvirt] [PATCH] util, remote: Fixing the sending of stream when length is defined.

2018-03-04 Thread Julio Faracco
I'm not sure about this part. When offset is equal of length, nbytes is 0 and the function will return 0. Do you see any possible problems to remove this part? I checked all ret = 0 and I'm not seeing problems until now. > -if (got == 0) > -break; > - -- libvir-list mailing

[libvirt] [PATCH] util, remote: Fixing the sending of stream when length is defined.

2018-03-04 Thread Julio Faracco
When a length of a file is defined, the responsible thread to send stream is finishing inappropriately. It is happening because there is wrong conditional which compares an offset with the length and because of that the code throws ENOSPC error. To test it: virsh# vol-upload ... --length N