Re: [libvirt] [PATCH] util: Create virsecret module adding virSecretGetSecretString

2016-04-04 Thread John Ferlan
[...] >> >> The secret driver should be calling functions from src/util, not the >> other way around. >> >> Could this function be moved into src/secret? >> > > Won't that place dependencies on secret_driver for libxl_driver and > qemu_driver? IOW: Some sort of Makefile magic to get a symbol

Re: [libvirt] [PATCH] util: Create virsecret module adding virSecretGetSecretString

2016-04-04 Thread John Ferlan
On 04/04/2016 10:33 AM, Ján Tomko wrote: > On Thu, Mar 31, 2016 at 11:05:07AM -0400, John Ferlan wrote: >> Commit id 'fb2bd208' essentially copied the qemuGetSecretString >> creating an libxlGetSecretString. Rather than have multiple copies >> of the same code, create virsecret.{c,h} files and

Re: [libvirt] [PATCH] util: Create virsecret module adding virSecretGetSecretString

2016-04-04 Thread Ján Tomko
On Thu, Mar 31, 2016 at 11:05:07AM -0400, John Ferlan wrote: > Commit id 'fb2bd208' essentially copied the qemuGetSecretString > creating an libxlGetSecretString. Rather than have multiple copies > of the same code, create virsecret.{c,h} files and place the common > function in there. > > Usage

[libvirt] [PATCH] util: Create virsecret module adding virSecretGetSecretString

2016-03-31 Thread John Ferlan
Commit id 'fb2bd208' essentially copied the qemuGetSecretString creating an libxlGetSecretString. Rather than have multiple copies of the same code, create virsecret.{c,h} files and place the common function in there. Usage is from both qemu_command.c and libxl_conf.c Signed-off-by: John Ferlan