Re: [libvirt] [PATCH] util: Forbid calling hash APIs from iterator callback

2011-03-10 Thread Daniel Veillard
On Wed, Mar 09, 2011 at 02:20:37PM +0100, Jiri Denemark wrote: Calling most hash APIs is not safe from inside of an iterator callback. Exceptions are APIs that do not modify the hash table and removing current hash entry from virHashFroEach callback. This patch make all APIs which are not

[libvirt] [PATCH] util: Forbid calling hash APIs from iterator callback

2011-03-09 Thread Jiri Denemark
Calling most hash APIs is not safe from inside of an iterator callback. Exceptions are APIs that do not modify the hash table and removing current hash entry from virHashFroEach callback. This patch make all APIs which are not safe fail instead of just relying on the callback being nice not

Re: [libvirt] [PATCH] util: Forbid calling hash APIs from iterator callback

2011-03-09 Thread Eric Blake
On 03/09/2011 06:20 AM, Jiri Denemark wrote: Calling most hash APIs is not safe from inside of an iterator callback. Exceptions are APIs that do not modify the hash table and removing current hash entry from virHashFroEach callback. s/Fro/For/ ACK. -- Eric Blake ebl...@redhat.com