Re: [libvirt] [PATCH] util: eliminate use after free in callers of virNetDevLinkDump

2014-10-26 Thread Laine Stump
On 10/24/2014 02:51 PM, Eric Blake wrote: ACK. For how few callers use it, your approach of making the caller free the netlink data after use seems fine. Thanks, I've pushed it, and will try to remember to backport it to all the -maint branches. -- libvir-list mailing list

[libvirt] [PATCH] util: eliminate use after free in callers of virNetDevLinkDump

2014-10-24 Thread Laine Stump
virNetDevLinkDump() gets a message from netlink into resp, then calls nlmsg_parse() to fill the table tb with pointers into resp. It then returns tb to its caller, but not before freeing the buffer at resp. That means that all the callers of virNetDevLinkDump() are examining memory that has

Re: [libvirt] [PATCH] util: eliminate use after free in callers of virNetDevLinkDump

2014-10-24 Thread Eric Blake
On 10/24/2014 11:57 AM, Laine Stump wrote: virNetDevLinkDump() gets a message from netlink into resp, then calls nlmsg_parse() to fill the table tb with pointers into resp. It then returns tb to its caller, but not before freeing the buffer at resp. That means that all the callers of