Re: [libvirt] [PATCH] util: eventpoll: Survive EBADF on macOS

2018-08-23 Thread Daniel P . Berrangé
On Thu, Aug 23, 2018 at 01:54:46AM +0300, Roman Bolshakov wrote: > On Wed, Aug 22, 2018 at 10:41:18AM +0100, Daniel P. Berrangé wrote: > > I don't think we should go through the dispatch code when > > we get EBADF, as the contents of the 'revents' fields are > > undefined after we get an error. > >

Re: [libvirt] [PATCH] util: eventpoll: Survive EBADF on macOS

2018-08-22 Thread Roman Bolshakov
On Wed, Aug 22, 2018 at 10:41:18AM +0100, Daniel P. Berrangé wrote: > I don't think we should go through the dispatch code when > we get EBADF, as the contents of the 'revents' fields are > undefined after we get an error. > > We should jump straight to the end where we have > "eventLoop.running =

Re: [libvirt] [PATCH] util: eventpoll: Survive EBADF on macOS

2018-08-22 Thread Daniel P . Berrangé
On Wed, Aug 22, 2018 at 12:12:03AM +0300, Roman Bolshakov wrote: > Fixes: > https://www.redhat.com/archives/libvir-list/2017-January/msg00978.html > > QEMU is probed through monitor fd to check capabilities during libvirtd init. > The monitor fd is closed after probing by virQEMUCapsInitQMPCommand

[libvirt] [PATCH] util: eventpoll: Survive EBADF on macOS

2018-08-21 Thread Roman Bolshakov
Fixes: https://www.redhat.com/archives/libvir-list/2017-January/msg00978.html QEMU is probed through monitor fd to check capabilities during libvirtd init. The monitor fd is closed after probing by virQEMUCapsInitQMPCommandFree that calls virQEMUCapsInitQMPCommandAbort that calls qemuMonitorClose,