Re: [libvirt] [PATCH] util: fix crash when starting macvtap interfaces

2012-04-26 Thread Alex Jia
On 04/26/2012 04:46 AM, Eric Blake wrote: On 04/25/2012 02:01 PM, Laine Stump wrote: This patch resolves https://bugzilla.redhat.com/show_bug.cgi?id=815270 The function virNetDevMacVLanVPortProfileRegisterCallback() takes an arg virtPortProfile, and was checking it for non-NULL before using

Re: [libvirt] [PATCH] util: fix crash when starting macvtap interfaces

2012-04-26 Thread Laine Stump
On 04/25/2012 04:46 PM, Eric Blake wrote: On 04/25/2012 02:01 PM, Laine Stump wrote: This patch resolves https://bugzilla.redhat.com/show_bug.cgi?id=815270 The function virNetDevMacVLanVPortProfileRegisterCallback() takes an arg virtPortProfile, and was checking it for non-NULL before using

Re: [libvirt] [PATCH] util: fix crash when starting macvtap interfaces

2012-04-26 Thread Laine Stump
On 04/26/2012 02:12 AM, Alex Jia wrote: On 04/26/2012 04:46 AM, Eric Blake wrote: On 04/25/2012 02:01 PM, Laine Stump wrote: This patch resolves https://bugzilla.redhat.com/show_bug.cgi?id=815270 The function virNetDevMacVLanVPortProfileRegisterCallback() takes an arg virtPortProfile, and

Re: [libvirt] [PATCH] util: fix crash when starting macvtap interfaces

2012-04-26 Thread Eric Blake
On 04/26/2012 01:44 AM, Alex Jia wrote: As Laine and I discussed on IRC, I'm half wondering if we should just do: #ifdef STATIC_ANALYSIS /* attributes supported */ # define ATTRIBUTE_NONNULL(n) __attribute__((__nonnull__(n))) #else # define ATTRIBUTE_NONNULL(n) /* empty, due to gcc

Re: [libvirt] [PATCH] util: fix crash when starting macvtap interfaces

2012-04-26 Thread Alex Jia
: Thursday, April 26, 2012 8:55:18 PM Subject: Re: [libvirt] [PATCH] util: fix crash when startingmacvtap interfaces On 04/26/2012 01:44 AM, Alex Jia wrote: As Laine and I discussed on IRC, I'm half wondering if we should just do: #ifdef STATIC_ANALYSIS /* attributes supported */ # define

[libvirt] [PATCH] util: fix crash when starting macvtap interfaces

2012-04-25 Thread Laine Stump
This patch resolves https://bugzilla.redhat.com/show_bug.cgi?id=815270 The function virNetDevMacVLanVPortProfileRegisterCallback() takes an arg virtPortProfile, and was checking it for non-NULL before using it. However, the prototype for virNetDevMacVLanPortProfileRegisterCallback had marked that

Re: [libvirt] [PATCH] util: fix crash when starting macvtap interfaces

2012-04-25 Thread Eric Blake
On 04/25/2012 02:01 PM, Laine Stump wrote: This patch resolves https://bugzilla.redhat.com/show_bug.cgi?id=815270 The function virNetDevMacVLanVPortProfileRegisterCallback() takes an arg virtPortProfile, and was checking it for non-NULL before using it. However, the prototype for