Re: [libvirt] [PATCH] util: portably check for unchanged uid

2013-03-15 Thread Eric Blake
On 03/15/2013 10:47 AM, Laine Stump wrote: > On 03/14/2013 06:35 PM, Eric Blake wrote: >> We've already scrubbed for comparisons of 'uid_t == -1' (which fail >> on platforms where uid_t is a u16), but another one snuck in. > > ACK (and sorry for the botched "bugfix" :-/) > >> +# Don't compare *i

Re: [libvirt] [PATCH] util: portably check for unchanged uid

2013-03-15 Thread Laine Stump
On 03/14/2013 06:35 PM, Eric Blake wrote: > We've already scrubbed for comparisons of 'uid_t == -1' (which fail > on platforms where uid_t is a u16), but another one snuck in. ACK (and sorry for the botched "bugfix" :-/) > > * src/util/virutil.c (virSetUIDGIDWithCaps): Correct uid comparison. > *

[libvirt] [PATCH] util: portably check for unchanged uid

2013-03-14 Thread Eric Blake
We've already scrubbed for comparisons of 'uid_t == -1' (which fail on platforms where uid_t is a u16), but another one snuck in. * src/util/virutil.c (virSetUIDGIDWithCaps): Correct uid comparison. * cfg.mk (sc_prohibit_risky_id_promotion): New rule. --- cfg.mk | 6 ++ src/util/v