Re: [libvirt] [PATCH] util: storage: Fix build after 25924dec0f9329d429aadae14e273602307e2214

2014-07-09 Thread Peter Krempa
On 07/09/14 15:01, Eric Blake wrote: > On 07/09/2014 02:05 AM, Peter Krempa wrote: >> The commit referenced above changed function arguments of >> virStorageFileGetMetadataFromBuf() but didn't tweak the >> ATTRIBUTE_NONNULL tied to them. This was caught by coverity as it >> actually obeys them. We

Re: [libvirt] [PATCH] util: storage: Fix build after 25924dec0f9329d429aadae14e273602307e2214

2014-07-09 Thread Eric Blake
On 07/09/2014 02:05 AM, Peter Krempa wrote: > The commit referenced above changed function arguments of > virStorageFileGetMetadataFromBuf() but didn't tweak the > ATTRIBUTE_NONNULL tied to them. This was caught by coverity as it > actually obeys them. We disabled them for GCC and thus it didn't sh

Re: [libvirt] [PATCH] util: storage: Fix build after 25924dec0f9329d429aadae14e273602307e2214

2014-07-09 Thread Peter Krempa
On 07/09/14 10:12, Michal Privoznik wrote: > On 09.07.2014 10:05, Peter Krempa wrote: >> The commit referenced above changed function arguments of >> virStorageFileGetMetadataFromBuf() but didn't tweak the >> ATTRIBUTE_NONNULL tied to them. This was caught by coverity as it >> actually obeys them.

Re: [libvirt] [PATCH] util: storage: Fix build after 25924dec0f9329d429aadae14e273602307e2214

2014-07-09 Thread Michal Privoznik
On 09.07.2014 10:05, Peter Krempa wrote: The commit referenced above changed function arguments of virStorageFileGetMetadataFromBuf() but didn't tweak the ATTRIBUTE_NONNULL tied to them. This was caught by coverity as it actually obeys them. We disabled them for GCC and thus it didn't show up. A

[libvirt] [PATCH] util: storage: Fix build after 25924dec0f9329d429aadae14e273602307e2214

2014-07-09 Thread Peter Krempa
The commit referenced above changed function arguments of virStorageFileGetMetadataFromBuf() but didn't tweak the ATTRIBUTE_NONNULL tied to them. This was caught by coverity as it actually obeys them. We disabled them for GCC and thus it didn't show up. Additionally in commit 3ea661deeabadc3c114df