Re: [libvirt] [PATCH] uuid: fix off-by-one

2012-01-12 Thread Michal Privoznik
On 12.01.2012 01:46, Eric Blake wrote: Detected by Coverity. Although unlikely, if we are ever started with stdin closed, we could reach a situation where we open a uuid file but then fail to close it, making that file the new stdin for the rest of the process. * src/util/uuid.c

Re: [libvirt] [PATCH] uuid: fix off-by-one

2012-01-12 Thread Eric Blake
On 01/12/2012 01:30 AM, Michal Privoznik wrote: On 12.01.2012 01:46, Eric Blake wrote: Detected by Coverity. Although unlikely, if we are ever started with stdin closed, we could reach a situation where we open a uuid file but then fail to close it, making that file the new stdin for the

[libvirt] [PATCH] uuid: fix off-by-one

2012-01-11 Thread Eric Blake
Detected by Coverity. Although unlikely, if we are ever started with stdin closed, we could reach a situation where we open a uuid file but then fail to close it, making that file the new stdin for the rest of the process. * src/util/uuid.c (getDMISystemUUID): Allow for stdin. ---