Re: [libvirt] [PATCH] virDomainDefCopy: Skip ostype checks

2018-06-04 Thread Ján Tomko
On Mon, Jun 04, 2018 at 12:23:50PM +0200, Michal Privoznik wrote: On 06/02/2018 02:23 PM, Ján Tomko wrote: On Sat, Jun 02, 2018 at 12:57:39PM +0200, Michal Privoznik wrote: When parsing domain XML the virCapsDomainData lookup is performed in order to fill in missing def->os.arch and

Re: [libvirt] [PATCH] virDomainDefCopy: Skip ostype checks

2018-06-04 Thread Michal Privoznik
On 06/02/2018 02:23 PM, Ján Tomko wrote: > On Sat, Jun 02, 2018 at 12:57:39PM +0200, Michal Privoznik wrote: >> When parsing domain XML the virCapsDomainData lookup is performed >> in order to fill in missing def->os.arch and def->os.machine >> strings. Well, when doing copy of already existing

Re: [libvirt] [PATCH] virDomainDefCopy: Skip ostype checks

2018-06-02 Thread Ján Tomko
On Sat, Jun 02, 2018 at 12:57:39PM +0200, Michal Privoznik wrote: When parsing domain XML the virCapsDomainData lookup is performed in order to fill in missing def->os.arch and def->os.machine strings. Well, when doing copy of already existing virDomainDef we don't want any automagic fill in of

[libvirt] [PATCH] virDomainDefCopy: Skip ostype checks

2018-06-02 Thread Michal Privoznik
When parsing domain XML the virCapsDomainData lookup is performed in order to fill in missing def->os.arch and def->os.machine strings. Well, when doing copy of already existing virDomainDef we don't want any automagic fill in of defaults (and those two strings are going to be provided at this