Re: [libvirt] [PATCH] virDomainDiskDef: Turn @device into enum

2015-09-28 Thread Laine Stump
On 09/17/2015 11:37 AM, Michal Privoznik wrote: It's used as enum everywhere, so why store its value in an int? There are a lot of these. I *think* the only reason this was done anywhere in the first place was because the size of an enum isn't guaranteed to be the same across different

Re: [libvirt] [PATCH] virDomainDiskDef: Turn @device into enum

2015-09-28 Thread Daniel P. Berrange
On Mon, Sep 28, 2015 at 12:35:31PM -0400, Laine Stump wrote: > On 09/17/2015 11:37 AM, Michal Privoznik wrote: > >It's used as enum everywhere, so why store its value in an int? > > There are a lot of these. I *think* the only reason this was done anywhere > in the first place was because the

Re: [libvirt] [PATCH] virDomainDiskDef: Turn @device into enum

2015-09-28 Thread John Ferlan
On 09/17/2015 11:37 AM, Michal Privoznik wrote: > It's used as enum everywhere, so why store its value in an int? > > Signed-off-by: Michal Privoznik > --- > src/conf/domain_conf.c | 9 +++-- > src/conf/domain_conf.h | 2 +- > src/qemu/qemu_command.c | 2 ++ >

[libvirt] [PATCH] virDomainDiskDef: Turn @device into enum

2015-09-17 Thread Michal Privoznik
It's used as enum everywhere, so why store its value in an int? Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c | 9 +++-- src/conf/domain_conf.h | 2 +- src/qemu/qemu_command.c | 2 ++ src/vmx/vmx.c| 6 +++--- src/vmx/vmx.h| 2 +-