Re: [libvirt] [PATCH] virDomainInterfaceAddresses: Allow API on RO connection too

2016-01-11 Thread Michal Privoznik
On 11.01.2016 13:11, Daniel P. Berrange wrote: > On Mon, Jan 11, 2016 at 12:52:36PM +0100, Michal Privoznik wrote: >> This API does not change domain state. It's merely like >> virDomainGetXMLDesc() - and we don't reject RO connections there. >> There's no reason to reject them here. > > This API

Re: [libvirt] [PATCH] virDomainInterfaceAddresses: Allow API on RO connection too

2016-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2016 at 12:52:36PM +0100, Michal Privoznik wrote: > This API does not change domain state. It's merely like > virDomainGetXMLDesc() - and we don't reject RO connections there. > There's no reason to reject them here. This API can result in talking to the guest agent IIRC, which

[libvirt] [PATCH] virDomainInterfaceAddresses: Allow API on RO connection too

2016-01-11 Thread Michal Privoznik
This API does not change domain state. It's merely like virDomainGetXMLDesc() - and we don't reject RO connections there. There's no reason to reject them here. Signed-off-by: Michal Privoznik --- src/libvirt-domain.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [libvirt] [PATCH] virDomainInterfaceAddresses: Allow API on RO connection too

2016-01-11 Thread Daniel P. Berrange
On Mon, Jan 11, 2016 at 01:20:38PM +0100, Michal Privoznik wrote: > On 11.01.2016 13:11, Daniel P. Berrange wrote: > > On Mon, Jan 11, 2016 at 12:52:36PM +0100, Michal Privoznik wrote: > >> This API does not change domain state. It's merely like > >> virDomainGetXMLDesc() - and we don't reject RO

Re: [libvirt] [PATCH] virDomainInterfaceAddresses: Allow API on RO connection too

2016-01-11 Thread Michal Privoznik
On 11.01.2016 13:26, Daniel P. Berrange wrote: > On Mon, Jan 11, 2016 at 01:20:38PM +0100, Michal Privoznik wrote: >> On 11.01.2016 13:11, Daniel P. Berrange wrote: >>> On Mon, Jan 11, 2016 at 12:52:36PM +0100, Michal Privoznik wrote: This API does not change domain state. It's merely like