Re: [libvirt] [PATCH] virDomainMemoryStats: avoid null dereference

2011-02-15 Thread Eric Blake
On 02/14/2011 05:38 PM, Laine Stump wrote: On 02/14/2011 06:25 PM, Eric Blake wrote: * src/libvirt.c (virDomainMemoryStats): Check domain before flags. --- Another valid bug found by clang. User's generally should't call virDomainMemoryStats(NULL,...), but we don't forbid it elsewhere, and

Re: [libvirt] [PATCH] virDomainMemoryStats: avoid null dereference

2011-02-14 Thread Laine Stump
On 02/14/2011 06:25 PM, Eric Blake wrote: * src/libvirt.c (virDomainMemoryStats): Check domain before flags. --- Another valid bug found by clang. User's generally should't call virDomainMemoryStats(NULL,...), but we don't forbid it elsewhere, and doing so is not supposed to crash libvirt.