[libvirt] [PATCH] virDomainNetDefParseXML: avoid leak upon multiple filterref

2010-05-18 Thread Jim Meyering
The offending code below appears in this loop: virNWFilterHashTablePtr filterparams = NULL; ... cur = node-children; while (cur != NULL) { ... } so the first assignment works fine, but second and subsequent ones leak the buffer returned by each preceding

Re: [libvirt] [PATCH] virDomainNetDefParseXML: avoid leak upon multiple filterref

2010-05-18 Thread Eric Blake
On 05/18/2010 02:22 AM, Jim Meyering wrote: * src/conf/domain_conf.c (virDomainNetDefParseXML): Don't leak memory when parsing two or more filterref elements. --- src/conf/domain_conf.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/conf/domain_conf.c

Re: [libvirt] [PATCH] virDomainNetDefParseXML: avoid leak upon multiple filterref

2010-05-18 Thread Stefan Berger
On Tue, 2010-05-18 at 08:22 -0600, Eric Blake wrote: On 05/18/2010 02:22 AM, Jim Meyering wrote: * src/conf/domain_conf.c (virDomainNetDefParseXML): Don't leak memory when parsing two or more filterref elements. --- src/conf/domain_conf.c |1 + 1 files changed, 1 insertions(+), 0

Re: [libvirt] [PATCH] virDomainNetDefParseXML: avoid leak upon multiple filterref

2010-05-18 Thread Jim Meyering
Stefan Berger wrote: On Tue, 2010-05-18 at 08:22 -0600, Eric Blake wrote: On 05/18/2010 02:22 AM, Jim Meyering wrote: * src/conf/domain_conf.c (virDomainNetDefParseXML): Don't leak memory when parsing two or more filterref elements. --- src/conf/domain_conf.c |1 + 1 files