Re: [libvirt] [PATCH] virStorageNetHostDef: Turn @port into integer

2017-07-20 Thread Peter Krempa
On Wed, Jul 19, 2017 at 17:58:15 +0200, Peter Krempa wrote: > On Wed, Jul 19, 2017 at 17:26:27 +0200, Michal Privoznik wrote: > > Currently, @port is type of string. Well, that's overkill and > > waste of memory. Port is always an integer. Use it as such. > > > > Signed-off-by: Michal Privoznik >

Re: [libvirt] [PATCH] virStorageNetHostDef: Turn @port into integer

2017-07-20 Thread Michal Privoznik
On 07/19/2017 05:58 PM, Peter Krempa wrote: > On Wed, Jul 19, 2017 at 17:26:27 +0200, Michal Privoznik wrote: >> Currently, @port is type of string. Well, that's overkill and >> waste of memory. Port is always an integer. Use it as such. >> >> Signed-off-by: Michal Privoznik >> --- >> src/conf/do

Re: [libvirt] [PATCH] virStorageNetHostDef: Turn @port into integer

2017-07-19 Thread Peter Krempa
On Wed, Jul 19, 2017 at 17:26:27 +0200, Michal Privoznik wrote: > Currently, @port is type of string. Well, that's overkill and > waste of memory. Port is always an integer. Use it as such. > > Signed-off-by: Michal Privoznik > --- > src/conf/domain_conf.c| 25 ++-- > src/li

[libvirt] [PATCH] virStorageNetHostDef: Turn @port into integer

2017-07-19 Thread Michal Privoznik
Currently, @port is type of string. Well, that's overkill and waste of memory. Port is always an integer. Use it as such. Signed-off-by: Michal Privoznik --- src/conf/domain_conf.c| 25 ++-- src/libxl/libxl_conf.c| 2 +- src/qemu/qemu_block.c