Re: [libvirt] [PATCH] virStorageVolWipe: Document that wiping journaled FS is useless

2015-12-21 Thread Vasiliy Tolstov
2015-12-21 13:39 GMT+03:00 Michal Privoznik : > I'm no expert but I think fstrim is no help here - it merely reclaims > free space on a disk, but raw data is still accessible. At least can be > if disk does not implement DRAT (Deterministic Read After Trim) (read of > zeroes

Re: [libvirt] [PATCH] virStorageVolWipe: Document that wiping journaled FS is useless

2015-12-21 Thread Vasiliy Tolstov
2015-12-21 10:18 GMT+03:00 Michal Privoznik : > None that I know of. It's just that I've came across some discussion in > the office about volWipe and it just appeared to me that we ought to > have this documented. May be in this case doing FITRIM ioctl ? As i understand

Re: [libvirt] [PATCH] virStorageVolWipe: Document that wiping journaled FS is useless

2015-12-21 Thread Michal Privoznik
On 21.12.2015 11:20, Vasiliy Tolstov wrote: > 2015-12-21 10:18 GMT+03:00 Michal Privoznik : >> None that I know of. It's just that I've came across some discussion in >> the office about volWipe and it just appeared to me that we ought to >> have this documented. > > > May

Re: [libvirt] [PATCH] virStorageVolWipe: Document that wiping journaled FS is useless

2015-12-20 Thread Michal Privoznik
On 18.12.2015 20:30, John Ferlan wrote: > > > On 12/17/2015 05:10 AM, Michal Privoznik wrote: >> So you have a libvirt volume that you want to wipe out. But lets >> say that the volume is actually a file stored on a journaled >> filesystem. Overwriting it with zeroes or a pattern does not mean

Re: [libvirt] [PATCH] virStorageVolWipe: Document that wiping journaled FS is useless

2015-12-18 Thread John Ferlan
On 12/17/2015 05:10 AM, Michal Privoznik wrote: > So you have a libvirt volume that you want to wipe out. But lets > say that the volume is actually a file stored on a journaled > filesystem. Overwriting it with zeroes or a pattern does not mean > that corresponding physical location on the disk

[libvirt] [PATCH] virStorageVolWipe: Document that wiping journaled FS is useless

2015-12-17 Thread Michal Privoznik
So you have a libvirt volume that you want to wipe out. But lets say that the volume is actually a file stored on a journaled filesystem. Overwriting it with zeroes or a pattern does not mean that corresponding physical location on the disk is overwritten too, due to journaling. It's the same