Re: [libvirt] [PATCH] virconf: properly set the end of content

2017-11-09 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 04:01:48PM -0700, Jim Fehlig wrote: > There was a recent report of the xen-xl converter not handling > config files missing an ending newline > > https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html > > Commit 3cc2a9e0 fixed a similar problem when

Re: [libvirt] [PATCH] virconf: properly set the end of content

2017-11-08 Thread Jim Fehlig
On 11/08/2017 01:56 AM, Daniel P. Berrange wrote: On Tue, Nov 07, 2017 at 03:37:46PM -0700, Jim Fehlig wrote: There was a recent report of the xen-xl converter not handling config files missing an ending newline https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html Commit

[libvirt] [PATCH] virconf: properly set the end of content

2017-11-08 Thread Jim Fehlig
There was a recent report of the xen-xl converter not handling config files missing an ending newline https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html Commit 3cc2a9e0 fixed a similar problem when parsing content of a file but missed parsing in-memory content. But AFAICT,

Re: [libvirt] [PATCH] virconf: properly set the end of content

2017-11-08 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 03:37:46PM -0700, Jim Fehlig wrote: > There was a recent report of the xen-xl converter not handling > config files missing an ending newline > > https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html > > Commit 3cc2a9e0 fixed a similar problem when

[libvirt] [PATCH] virconf: properly set the end of content

2017-11-07 Thread Jim Fehlig
There was a recent report of the xen-xl converter not handling config files missing an ending newline https://www.redhat.com/archives/libvir-list/2017-October/msg01353.html Commit 3cc2a9e0 fixed a similar problem when parsing content of a file but missed parsing in-memory content. But AFAICT,