Re: [libvirt] [PATCH] virdbustest: Don't pass number of arguments as long long

2013-07-25 Thread Daniel Veillard
On Wed, Jul 24, 2013 at 03:41:17PM -0600, Eric Blake wrote: On 07/24/2013 03:29 PM, Guido Günther wrote: since sizeof(size_t) != sizeof(long long) on 32bit archs. This unbreaks virdbustest which otherwise fails like: +++ b/tests/virdbustest.c @@ -195,7 +195,7 @@ static int

Re: [libvirt] [PATCH] virdbustest: Don't pass number of arguments as long long

2013-07-25 Thread Guido Günther
Hi Eric, On Wed, Jul 24, 2013 at 03:41:17PM -0600, Eric Blake wrote: On 07/24/2013 03:29 PM, Guido Günther wrote: since sizeof(size_t) != sizeof(long long) on 32bit archs. This unbreaks virdbustest which otherwise fails like: +++ b/tests/virdbustest.c @@ -195,7 +195,7 @@ static

Re: [libvirt] [PATCH] virdbustest: Don't pass number of arguments as long long

2013-07-25 Thread Daniel P. Berrange
On Wed, Jul 24, 2013 at 03:41:17PM -0600, Eric Blake wrote: On 07/24/2013 03:29 PM, Guido Günther wrote: since sizeof(size_t) != sizeof(long long) on 32bit archs. This unbreaks virdbustest which otherwise fails like: +++ b/tests/virdbustest.c @@ -195,7 +195,7 @@ static int

Re: [libvirt] [PATCH] virdbustest: Don't pass number of arguments as long long

2013-07-25 Thread Eric Blake
On 07/25/2013 03:27 AM, Daniel P. Berrange wrote: This fix looks correct, but it's annoying that we have to cast the 'a' length argument in every caller. I'm wondering if a better fix would be to virDBusMessageEncode to take an 'int' instead of a 'size_t' arg for a length; even though that

Re: [libvirt] [PATCH] virdbustest: Don't pass number of arguments as long long

2013-07-25 Thread Guido Günther
On Thu, Jul 25, 2013 at 07:37:48AM -0600, Eric Blake wrote: On 07/25/2013 03:27 AM, Daniel P. Berrange wrote: This fix looks correct, but it's annoying that we have to cast the 'a' length argument in every caller. I'm wondering if a better fix would be to virDBusMessageEncode to take an

[libvirt] [PATCH] virdbustest: Don't pass number of arguments as long long

2013-07-24 Thread Guido Günther
since sizeof(size_t) != sizeof(long long) on 32bit archs. This unbreaks virdbustest which otherwise fails like: (gdb) bt #0 __strlen_sse2_bsf () at ../sysdeps/i386/i686/multiarch/strlen-sse2-bsf.S:50 #1 0x405907d2 in ?? () from /lib/i386-linux-gnu/libdbus-1.so.3 #2 0x4057c140 in ?? ()

Re: [libvirt] [PATCH] virdbustest: Don't pass number of arguments as long long

2013-07-24 Thread Eric Blake
On 07/24/2013 03:29 PM, Guido Günther wrote: since sizeof(size_t) != sizeof(long long) on 32bit archs. This unbreaks virdbustest which otherwise fails like: +++ b/tests/virdbustest.c @@ -195,7 +195,7 @@ static int testMessageArray(const void *args ATTRIBUTE_UNUSED) if