Re: [libvirt] [PATCH] virobject: Improve documentation

2019-03-15 Thread Eric Blake
On 3/15/19 2:40 AM, Erik Skultety wrote: > On Thu, Mar 14, 2019 at 11:24:47PM -0500, Eric Blake wrote: >> I had to inspect the code to learn whether a final virObjectUnref() >> calls ALL dispose callbacks in child-to-parent order (akin to C++ >> destructors), or whether I manually had to call a

Re: [libvirt] [PATCH] virobject: Improve documentation

2019-03-15 Thread Erik Skultety
On Thu, Mar 14, 2019 at 11:24:47PM -0500, Eric Blake wrote: > I had to inspect the code to learn whether a final virObjectUnref() > calls ALL dispose callbacks in child-to-parent order (akin to C++ > destructors), or whether I manually had to call a parent-class dispose > when writing a child

[libvirt] [PATCH] virobject: Improve documentation

2019-03-14 Thread Eric Blake
I had to inspect the code to learn whether a final virObjectUnref() calls ALL dispose callbacks in child-to-parent order (akin to C++ destructors), or whether I manually had to call a parent-class dispose when writing a child class dispose method. The answer is the former. (Thankfully, since