[libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-07 Thread Xu He Jie
As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Add flag 'VSH_OFLAG_EMPTY_OK' to the option 'source' of attach-disk Signed-off-by: Xu He Jie --- tools/virsh.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Eric Blake
On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Hmm. virsh attach-disk --type cdrom --mode readonly myguest "" hdc might look a bit nicer as: virsh attach-disk --type cdrom --mode readonly

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Xu He Jie
于 2011年11月09日 07:08, Eric Blake 写道: On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Hmm. virsh attach-disk --type cdrom --mode readonly myguest "" hdc might look a bit nicer as: virsh attach-dis

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Osier Yang
On 11/09/2011 10:34 AM, Xu He Jie wrote: 于 2011年11月09日 07:08, Eric Blake 写道: On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Hmm. virsh attach-disk --type cdrom --mode readonly myguest "" hdc m

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Xu He Jie
于 2011年11月09日 11:05, Osier Yang 写道: On 11/09/2011 10:34 AM, Xu He Jie wrote: 于 2011年11月09日 07:08, Eric Blake 写道: On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#eject_DEV Hmm. virsh attach-disk --type c

Re: [libvirt] [PATCH] virsh: Add VSH_OFLAG_EMPTY_OK for attach-disk command

2011-11-08 Thread Osier Yang
On 11/09/2011 11:29 AM, Xu He Jie wrote: 于 2011年11月09日 11:05, Osier Yang 写道: On 11/09/2011 10:34 AM, Xu He Jie wrote: 于 2011年11月09日 07:08, Eric Blake 写道: On 11/08/2011 12:16 AM, Xu He Jie wrote: As the description of removing CDROM media from http://wiki.libvirt.org/page/QEMUSwitchToLibvirt#e