Re: [libvirt] [PATCH] virsh: Don't read nparams when virDomainGetMemoryParameters fails

2010-10-20 Thread Matthias Bolte
2010/10/20 Daniel Veillard : > On Wed, Oct 20, 2010 at 02:26:18PM +0200, Matthias Bolte wrote: >> Also exit early when nparams is 0. >> --- >>  tools/virsh.c |   13 + >>  1 files changed, 9 insertions(+), 4 deletions(-) > >  Okay, error message normalization sounds good too, > >    than

Re: [libvirt] [PATCH] virsh: Don't read nparams when virDomainGetMemoryParameters fails

2010-10-20 Thread Daniel Veillard
On Wed, Oct 20, 2010 at 02:26:18PM +0200, Matthias Bolte wrote: > Also exit early when nparams is 0. > --- > tools/virsh.c | 13 + > 1 files changed, 9 insertions(+), 4 deletions(-) Okay, error message normalization sounds good too, thanks ! Daniel -- Daniel Veillard

[libvirt] [PATCH] virsh: Don't read nparams when virDomainGetMemoryParameters fails

2010-10-20 Thread Matthias Bolte
Also exit early when nparams is 0. --- tools/virsh.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/tools/virsh.c b/tools/virsh.c index d1ef698..3e37b06 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -2941,17 +2941,22 @@ cmdMemtune(vshControl * ctl, const v