Re: [libvirt] [PATCH] virsh: Error prompt if one passes negative value for scheduler setting

2011-01-29 Thread Eric Blake
On 01/28/2011 07:40 PM, Osier Yang wrote: > I'm afraid changing on virStrToLong_u* will affect other codes, pretty > codes use them. > >> >>> Is there some codes that expects virStrToLong_{ui,ul,ull} to convert >>> the negative to {ui, ul, ull}? >> >> Probably, given the above arguments about -1 b

Re: [libvirt] [PATCH] virsh: Error prompt if one passes negative value for scheduler setting

2011-01-28 Thread Osier Yang
于 2011年01月28日 23:33, Eric Blake 写道: On 01/28/2011 05:11 AM, Osier Yang wrote: 于 2011年01月28日 20:02, Daniel P. Berrange 写道: On Fri, Jan 28, 2011 at 07:53:44PM +0800, Osier Yang wrote: As cgroup doesn't allow one writes negative into files like cpu.shares, (e.g. echo -1> /cgroup/cpu/libvirt/qem

Re: [libvirt] [PATCH] virsh: Error prompt if one passes negative value for scheduler setting

2011-01-28 Thread Daniel P. Berrange
On Fri, Jan 28, 2011 at 08:33:20AM -0700, Eric Blake wrote: > On 01/28/2011 05:11 AM, Osier Yang wrote: > > 于 2011年01月28日 20:02, Daniel P. Berrange 写道: > >> On Fri, Jan 28, 2011 at 07:53:44PM +0800, Osier Yang wrote: > >>> As cgroup doesn't allow one writes negative into files like cpu.shares, > >>

Re: [libvirt] [PATCH] virsh: Error prompt if one passes negative value for scheduler setting

2011-01-28 Thread Eric Blake
On 01/28/2011 05:11 AM, Osier Yang wrote: > 于 2011年01月28日 20:02, Daniel P. Berrange 写道: >> On Fri, Jan 28, 2011 at 07:53:44PM +0800, Osier Yang wrote: >>> As cgroup doesn't allow one writes negative into files like cpu.shares, >>> (e.g. echo -1> /cgroup/cpu/libvirt/qemu/rhel6/cpu.shares), user wil

Re: [libvirt] [PATCH] virsh: Error prompt if one passes negative value for scheduler setting

2011-01-28 Thread Osier Yang
于 2011年01月28日 20:02, Daniel P. Berrange 写道: On Fri, Jan 28, 2011 at 07:53:44PM +0800, Osier Yang wrote: As cgroup doesn't allow one writes negative into files like cpu.shares, (e.g. echo -1> /cgroup/cpu/libvirt/qemu/rhel6/cpu.shares), user will be confused if libvirt accepts negative value and

Re: [libvirt] [PATCH] virsh: Error prompt if one passes negative value for scheduler setting

2011-01-28 Thread Daniel P. Berrange
On Fri, Jan 28, 2011 at 07:53:44PM +0800, Osier Yang wrote: > As cgroup doesn't allow one writes negative into files like cpu.shares, > (e.g. echo -1> /cgroup/cpu/libvirt/qemu/rhel6/cpu.shares), user will be > confused if libvirt accepts negative value and converts it into unsigned > int (or long i

[libvirt] [PATCH] virsh: Error prompt if one passes negative value for scheduler setting

2011-01-28 Thread Osier Yang
As cgroup doesn't allow one writes negative into files like cpu.shares, (e.g. echo -1> /cgroup/cpu/libvirt/qemu/rhel6/cpu.shares), user will be confused if libvirt accepts negative value and converts it into unsigned int (or long int, etc) silently. * tools/virsh.c --- tools/virsh.c |6 --