On Thu, Oct 25, 2012 at 09:43:28 -0400, Dave Allan wrote:
> On Thu, Oct 25, 2012 at 07:16:35AM -0600, Eric Blake wrote:
> > I disagree - there's no point in keeping a hidden argument. It is a
> > disservice to users to make them have to pass a numeric flags value - if
> > they know they are talkin
On Thu, Oct 25, 2012 at 07:16:35AM -0600, Eric Blake wrote:
> On 10/25/2012 03:03 AM, Michal Privoznik wrote:
> >
> > While I agree that this design is broken I don't think we can do this.
> > Okay, for now we only support 0; but what if in the future we invent a
> > new flag? With current virsh o
On 10/25/2012 03:03 AM, Michal Privoznik wrote:
>
> While I agree that this design is broken I don't think we can do this.
> Okay, for now we only support 0; but what if in the future we invent a
> new flag? With current virsh one is able to use it however with your
> patch he isn't.
But you coul
On 10/25/12 11:03, Michal Privoznik wrote:
On 25.10.2012 10:22, Jiri Denemark wrote:
We always expose individual bits from flags as separate options rather
than exposing a raw flags options. Since virNodeSuspendForDuration does
not currently support any flags, the only way of using this --flags
On 25.10.2012 10:22, Jiri Denemark wrote:
> We always expose individual bits from flags as separate options rather
> than exposing a raw flags options. Since virNodeSuspendForDuration does
> not currently support any flags, the only way of using this --flags
> options that would not fail is "--flag
On 10/25/2012 04:22 PM, Jiri Denemark wrote:
We always expose individual bits from flags as separate options rather
than exposing a raw flags options. Since virNodeSuspendForDuration does
not currently support any flags, the only way of using this --flags
options that would not fail is "--flags 0
We always expose individual bits from flags as separate options rather
than exposing a raw flags options. Since virNodeSuspendForDuration does
not currently support any flags, the only way of using this --flags
options that would not fail is "--flags 0", which is equivalent to
omitting the option.