于 2010年12月03日 23:15, Eric Blake 写道:
On 12/03/2010 02:17 AM, Justin Clift wrote:
On 03/12/2010, at 6:34 PM, Osier Yang wrote:
static const vshCmdOptDef opts_help[] = {
-{command, VSH_OT_DATA, 0, N_(Prints global help or command specific
help.)},
-{group, VSH_OT_DATA, 0, N_(Prints
于 2010年12月03日 23:24, Eric Blake 写道:
On 12/03/2010 12:34 AM, Osier Yang wrote:
Remove the optional option group, as cmdHelp should accepts
only one option, and rename option command as command-or-group,
(virsh help supports both command and command group now, and user
nealy uses the options, so
On 03/12/2010, at 6:34 PM, Osier Yang wrote:
static const vshCmdOptDef opts_help[] = {
-{command, VSH_OT_DATA, 0, N_(Prints global help or command specific
help.)},
-{group, VSH_OT_DATA, 0, N_(Prints global help or help for a group of
related commands.)},
+{command-or-group,
-name = vshCommandOptString(cmd, command, NULL);
-
-if (!name)
-name = vshCommandOptString(cmd, group, NULL);
+name = vshCommandOptString(cmd, command-or-group, NULL);
NACK. This breaks backwards compatibility for anyone with scripts already using
--command:
Don't
On 03/12/2010, at 8:33 PM, Osier Yang wrote:
Don't think anyone really used --command, our test programs
even doesn't use it.
Yeah. The problem is that we don't know, even if it's unlikely.
I'm thinking removing the option, when it's not important that we
do, is probably the safer idea.
So
On 12/03/2010 02:17 AM, Justin Clift wrote:
On 03/12/2010, at 6:34 PM, Osier Yang wrote:
static const vshCmdOptDef opts_help[] = {
-{command, VSH_OT_DATA, 0, N_(Prints global help or command specific
help.)},
-{group, VSH_OT_DATA, 0, N_(Prints global help or help for a group of
On 12/03/2010 12:34 AM, Osier Yang wrote:
Remove the optional option group, as cmdHelp should accepts
only one option, and rename option command as command-or-group,
(virsh help supports both command and command group now, and user
nealy uses the options, so it doesn't matter much for it being
On 04/12/2010, at 2:24 AM, Eric Blake wrote:
On 12/03/2010 12:34 AM, Osier Yang wrote:
Remove the optional option group, as cmdHelp should accepts
only one option, and rename option command as command-or-group,
(virsh help supports both command and command group now, and user
nealy uses the
On 04/12/2010, at 4:12 AM, Justin Clift wrote:
On 04/12/2010, at 2:24 AM, Eric Blake wrote:
On 12/03/2010 12:34 AM, Osier Yang wrote:
Remove the optional option group, as cmdHelp should accepts
only one option, and rename option command as command-or-group,
(virsh help supports both command
Remove the optional option group, as cmdHelp should accepts
only one option, and rename option command as command-or-group,
(virsh help supports both command and command group now, and user
nealy uses the options, so it doesn't matter much for it being longer,
:-)
* tools/virsh.c
---
10 matches
Mail list logo
