Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-18 Thread Doug Goldstein
On Fri, Nov 16, 2012 at 9:21 AM, Eric Blake wrote: > On 11/16/2012 03:51 AM, Jiri Denemark wrote: >> On Thu, Nov 08, 2012 at 12:39:45 -0500, Laine Stump wrote: > On Thu, Nov 08, 2012 at 03:24:07PM +0100, Daniel P. Berrange wrote: >> >> NACK to this patch. I think the current command na

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-16 Thread Eric Blake
On 11/16/2012 03:51 AM, Jiri Denemark wrote: > On Thu, Nov 08, 2012 at 12:39:45 -0500, Laine Stump wrote: On Thu, Nov 08, 2012 at 03:24:07PM +0100, Daniel P. Berrange wrote: > > NACK to this patch. I think the current command names are good. > Creating duplicates will make life wor

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-16 Thread Jiri Denemark
On Thu, Nov 08, 2012 at 12:39:45 -0500, Laine Stump wrote: > >> On Thu, Nov 08, 2012 at 03:24:07PM +0100, Daniel P. Berrange wrote: > >>> > >>> NACK to this patch. I think the current command names are good. > >>> Creating duplicates will make life worse. First, it creates > >>> divergance from the

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Jim Fehlig
Daniel P. Berrange wrote: > On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that >> the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping >> 'start', 'stop', 'restart'; might be easier to remember than the

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Laine Stump
On 11/08/2012 11:24 AM, Daniel P. Berrange wrote: > On Thu, Nov 08, 2012 at 10:51:14AM -0500, Dave Allan wrote: >> On Thu, Nov 08, 2012 at 03:24:07PM +0100, Daniel P. Berrange wrote: >>> On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Daniel P. Berrange
On Thu, Nov 08, 2012 at 08:55:27AM -0700, Eric Blake wrote: > On 11/08/2012 07:24 AM, Daniel P. Berrange wrote: > > On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: > >> https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that > >> the grouping 'boot', 'shutdown', 'reboot'; as w

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Daniel P. Berrange
On Thu, Nov 08, 2012 at 10:30:55AM -0500, James B. Byrne wrote: > > On Thu, November 8, 2012 09:24, Daniel P. Berrange wrote: > > > > > NACK to this patch. I think the current command names are good. > > Creating duplicates will make life worse. First, it creates > > divergance from the similarly

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Daniel P. Berrange
On Thu, Nov 08, 2012 at 10:51:14AM -0500, Dave Allan wrote: > On Thu, Nov 08, 2012 at 03:24:07PM +0100, Daniel P. Berrange wrote: > > On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: > > > https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that > > > the grouping 'boot', 'shutd

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Eric Blake
On 11/08/2012 07:24 AM, Daniel P. Berrange wrote: > On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that >> the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping >> 'start', 'stop', 'restart'; might be easier t

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Dave Allan
On Thu, Nov 08, 2012 at 03:24:07PM +0100, Daniel P. Berrange wrote: > On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that > > the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping > > 'start', 'stop', 'restar

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread James B. Byrne
On Thu, November 8, 2012 09:24, Daniel P. Berrange wrote: > > NACK to this patch. I think the current command names are good. > Creating duplicates will make life worse. First, it creates > divergance from the similarly named commands for networks, > storage and other objects. It also means scrip

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Viktor Mihajlovski
On 11/08/2012 03:25 PM, Daniel P. Berrange wrote: The 'shutdown' and 'reboot' commands use terms that apply to the operating system, because they *are* controlling the operating system, not the virtual machine. They directly result in the guest OS commands 'shutdown' and 'reboot' being invoked.

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Daniel P. Berrange
On Tue, Nov 06, 2012 at 09:30:15AM +0100, Viktor Mihajlovski wrote: > On 11/05/2012 08:59 PM, Eric Blake wrote: > > > >This patch documents both spellings. An alternative would be to > >leave the alternate spellings as hidden aliases (virsh has support > >for that), but still mention them in virsh

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-08 Thread Daniel P. Berrange
On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that > the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping > 'start', 'stop', 'restart'; might be easier to remember than the > current mix of 'start', 'shutdown

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-06 Thread Eric Blake
On 11/06/2012 07:31 AM, Laine Stump wrote: > On 11/06/2012 03:30 AM, Viktor Mihajlovski wrote: >> On 11/05/2012 08:59 PM, Eric Blake wrote: >>> @@ -1523,6 +1524,7 @@ be hot-plugged the next time the domain is >>> booted. As such, it must only be >>> used with the I<--config> flag, and not with t

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-06 Thread Eric Blake
On 11/06/2012 02:01 AM, Peter Krempa wrote: >>> =item B I [I<--mode acpi|agent>] >>> +=item B I [I<--mode acpi|agent>] >>> >>> Reboot a domain. This acts just as if the domain had the B >>> command run from the console. The command returns as soon as it has >> Now it would be a good time to

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-06 Thread Laine Stump
On 11/06/2012 03:30 AM, Viktor Mihajlovski wrote: > On 11/05/2012 08:59 PM, Eric Blake wrote: >> @@ -1523,6 +1524,7 @@ be hot-plugged the next time the domain is >> booted. As such, it must only be >> used with the I<--config> flag, and not with the I<--live> flag. >> >> =item B I [I<--mode ac

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-06 Thread Peter Krempa
On 11/06/12 09:30, Viktor Mihajlovski wrote: On 11/05/2012 08:59 PM, Eric Blake wrote: This patch documents both spellings. An alternative would be to leave the alternate spellings as hidden aliases (virsh has support for that), but still mention them in virsh.pod (see how we did an alias for

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-06 Thread Viktor Mihajlovski
On 11/05/2012 08:59 PM, Eric Blake wrote: This patch documents both spellings. An alternative would be to leave the alternate spellings as hidden aliases (virsh has support for that), but still mention them in virsh.pod (see how we did an alias for nodedev-dettach, for reference). In my opinion

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Jim Fehlig
Doug Goldstein wrote: > On Mon, Nov 5, 2012 at 4:57 PM, Eric Blake wrote: > >> On 11/05/2012 03:53 PM, Peter Krempa wrote: >> >>> On 11/05/12 20:59, Eric Blake wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 're

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Doug Goldstein
On Mon, Nov 5, 2012 at 4:57 PM, Eric Blake wrote: > On 11/05/2012 03:53 PM, Peter Krempa wrote: >> On 11/05/12 20:59, Eric Blake wrote: >>> https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that >>> the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping >>> 'start', 'stop',

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Eric Blake
On 11/05/2012 03:53 PM, Peter Krempa wrote: > On 11/05/12 20:59, Eric Blake wrote: >> https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that >> the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping >> 'start', 'stop', 'restart'; might be easier to remember than the >> curren

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Peter Krempa
On 11/05/12 20:59, Eric Blake wrote: https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping 'start', 'stop', 'restart'; might be easier to remember than the current mix of 'start', 'shutdown', 'reboot'. * tools/virsh-d

Re: [libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Dave Allan
On Mon, Nov 05, 2012 at 12:59:16PM -0700, Eric Blake wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that > the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping > 'start', 'stop', 'restart'; might be easier to remember than the > current mix of 'start', 'shutdown

[libvirt] [PATCH] virsh: add aliases 'boot', 'stop', and 'restart'

2012-11-05 Thread Eric Blake
https://bugzilla.redhat.com/show_bug.cgi?id=873344 suggested that the grouping 'boot', 'shutdown', 'reboot'; as well as the grouping 'start', 'stop', 'restart'; might be easier to remember than the current mix of 'start', 'shutdown', 'reboot'. * tools/virsh-domain.c (domManagementCmds): Add other