Re: [libvirt] [PATCH] virsh: add custom readline generator

2011-07-20 Thread Michal Privoznik
On 20.07.2011 10:42, Lai Jiangshan wrote: On 06/28/2011 05:29 PM, Michal Privoznik wrote: On 27.06.2011 21:39, Eric Blake wrote: On 06/27/2011 12:06 PM, Michal Privoznik wrote: That is, if you have command-based custom generators, then each command has to repeat parsing functionality, then cal

Re: [libvirt] [PATCH] virsh: add custom readline generator

2011-07-20 Thread Lai Jiangshan
On 06/28/2011 05:29 PM, Michal Privoznik wrote: > On 27.06.2011 21:39, Eric Blake wrote: >> On 06/27/2011 12:06 PM, Michal Privoznik wrote: That is, if you have command-based custom generators, then each command has to repeat parsing functionality, then call back to common list gener

Re: [libvirt] [PATCH] virsh: add custom readline generator

2011-06-28 Thread Michal Privoznik
On 27.06.2011 21:39, Eric Blake wrote: > On 06/27/2011 12:06 PM, Michal Privoznik wrote: >>> That is, if you have command-based custom generators, then each command >>> has to repeat parsing functionality, then call back to common list >>> generators; whereas if you have option-based custom generat

Re: [libvirt] [PATCH] virsh: add custom readline generator

2011-06-27 Thread Eric Blake
On 06/27/2011 12:06 PM, Michal Privoznik wrote: >> That is, if you have command-based custom generators, then each command >> has to repeat parsing functionality, then call back to common list >> generators; whereas if you have option-based custom generators, then you >> have fewer callbacks becaus

Re: [libvirt] [PATCH] virsh: add custom readline generator

2011-06-27 Thread Michal Privoznik
On 27.06.2011 19:37, Eric Blake wrote: > On 06/24/2011 12:42 AM, Lai Jiangshan wrote: >> Custom readline generator will help for some usecase. > > Indeed, this could be very nice as extended to more commands. > >> >> Also add a custom readline generator for the "help" command. >> >> Signed-off-by

Re: [libvirt] [PATCH] virsh: add custom readline generator

2011-06-27 Thread Eric Blake
On 06/24/2011 12:42 AM, Lai Jiangshan wrote: > Custom readline generator will help for some usecase. Indeed, this could be very nice as extended to more commands. > > Also add a custom readline generator for the "help" command. > > Signed-off-by: Lai Jiangshan > --- Hmm, this is a new virsh f

[libvirt] [PATCH] virsh: add custom readline generator

2011-06-23 Thread Lai Jiangshan
Custom readline generator will help for some usecase. Also add a custom readline generator for the "help" command. Signed-off-by: Lai Jiangshan --- diff --git a/tools/virsh.c b/tools/virsh.c index fcd254d..51e43c1 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -13575,7 +13575,7 @@ vshCloseLog