Re: [libvirt] [PATCH] virsh: fix build without readline

2018-01-13 Thread Roman Bogorodskiy
John Ferlan wrote: > > > On 01/13/2018 02:00 AM, Roman Bogorodskiy wrote: > > Completion in virsh is enabled when readline is available. However, > > when it's not available, we should: > > > > * avoid defining completers with completion functions; > > * in cmdComplete(), mark unused

Re: [libvirt] [PATCH] virsh: fix build without readline

2018-01-13 Thread John Ferlan
On 01/13/2018 02:00 AM, Roman Bogorodskiy wrote: > Completion in virsh is enabled when readline is available. However, > when it's not available, we should: > > * avoid defining completers with completion functions; > * in cmdComplete(), mark unused arguments when there's no readline with >

[libvirt] [PATCH] virsh: fix build without readline

2018-01-12 Thread Roman Bogorodskiy
Completion in virsh is enabled when readline is available. However, when it's not available, we should: * avoid defining completers with completion functions; * in cmdComplete(), mark unused arguments when there's no readline with ATTRIBUTE_UNUSED. --- tools/virsh-domain-monitor.c | 6