Re: [libvirt] [PATCH] virsh: fix no error output when parse cpulist fail

2015-05-06 Thread Luyao Huang
On 05/06/2015 07:28 PM, Ján Tomko wrote: On Wed, May 06, 2015 at 01:30:55PM +0800, Luyao Huang wrote: When we pass a invalid cpulist or the lastcpu in the cpulist exceed the maxcpu, we cannot get any error. like this: # virsh vcpupin test3 1 aaa # virsh vcpupin test3 1 1000 Because virBi

Re: [libvirt] [PATCH] virsh: fix no error output when parse cpulist fail

2015-05-06 Thread Ján Tomko
On Wed, May 06, 2015 at 01:30:55PM +0800, Luyao Huang wrote: > When we pass a invalid cpulist or the lastcpu in the > cpulist exceed the maxcpu, we cannot get any error. > like this: > > # virsh vcpupin test3 1 aaa > > # virsh vcpupin test3 1 1000 > > Because virBitmapParse() use virReportErro

[libvirt] [PATCH] virsh: fix no error output when parse cpulist fail

2015-05-05 Thread Luyao Huang
When we pass a invalid cpulist or the lastcpu in the cpulist exceed the maxcpu, we cannot get any error. like this: # virsh vcpupin test3 1 aaa # virsh vcpupin test3 1 1000 Because virBitmapParse() use virReportError() to set the error message, virsh client use vshError to output error. If we