On Fri, Nov 16, 2012 at 12:10:10PM +0100, Ján Tomko wrote:
> On 11/16/12 11:58, Christophe Fergeau wrote:
> > Shouldn't we call vshError with a different message in the !ret && !name
> > case?
> >
> > Christophe
> vshCommandOptDomain and vshLookupSnapshot already give reasonable error
> messages
On 11/16/12 11:58, Christophe Fergeau wrote:
> Shouldn't we call vshError with a different message in the !ret && !name case?
>
> Christophe
vshCommandOptDomain and vshLookupSnapshot already give reasonable error
messages in that case. For non-existent domains:
error: failed to get domain 'bla'
e
On Thu, Nov 15, 2012 at 11:37:32AM +0100, Ján Tomko wrote:
> If the domain can't be looked up, name is used unitialized after the
> cleanup label.
>
> Found by coverity.
> ---
> tools/virsh-snapshot.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/virsh-sn
On 15.11.2012 11:37, Ján Tomko wrote:
> If the domain can't be looked up, name is used unitialized after the
> cleanup label.
>
> Found by coverity.
> ---
> tools/virsh-snapshot.c |4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/virsh-snapshot.c b/tools/virs
If the domain can't be looked up, name is used unitialized after the
cleanup label.
Found by coverity.
---
tools/virsh-snapshot.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
index 4281109..0bd9583 100644
--- a/tools/v
