[libvirt] [PATCH] virsh: improve option handling

2011-07-15 Thread Eric Blake
The documentation for vshCommandOptString claims that it returns -1 on a missing required argument, but in reality, that error message was unreachable (it was buried inside an if clause that is true only if the argument was present). The code was so hairy that I decided a rewrite would make it

Re: [libvirt] [PATCH] virsh: improve option handling

2011-07-15 Thread Matthias Bolte
2011/7/15 Eric Blake ebl...@redhat.com: The documentation for vshCommandOptString claims that it returns -1 on a missing required argument, but in reality, that error message was unreachable (it was buried inside an if clause that is true only if the argument was present).  The code was so

Re: [libvirt] [PATCH] virsh: improve option handling

2011-07-15 Thread Eric Blake
On 07/15/2011 01:28 PM, Matthias Bolte wrote: 2011/7/15 Eric Blakeebl...@redhat.com: The documentation for vshCommandOptString claims that it returns -1 on a missing required argument, but in reality, that error message was unreachable (it was buried inside an if clause that is true only if the