Re: [libvirt] [PATCH] virsh: rework command parsing

2010-09-13 Thread Lai Jiangshan
On 09/13/2010 11:03 PM, Eric Blake wrote: > On 09/13/2010 01:41 AM, Lai Jiangshan wrote: >> And the usage was changed: >> old: >> virsh [options] [commands] >> >> new: >> virsh [options]... [commands string] >> virsh [options]... [ [command options]...] > > This needs a tweak, otherwise, executin

Re: [libvirt] [PATCH] virsh: rework command parsing

2010-09-13 Thread Lai Jiangshan
On 09/13/2010 11:03 PM, Eric Blake wrote: > On 09/13/2010 01:41 AM, Lai Jiangshan wrote: >> And the usage was changed: >> old: >> virsh [options] [commands] >> >> new: >> virsh [options]... [commands string] >> virsh [options]... [ [command options]...] > > This needs a tweak, otherwise, executin

Re: [libvirt] [PATCH] virsh: rework command parsing (was: Re: Question, how to use virDomainQemuMonitorCommand())

2010-09-13 Thread Daniel P. Berrange
On Mon, Sep 13, 2010 at 03:41:51PM +0800, Lai Jiangshan wrote: > On 09/09/2010 09:07 PM, Daniel P. Berrange wrote: > > > > While re-writing the command line mashing to not loose quotes would be > > nice, the more obvious fix is to not mash all the args back into a > > string at all. The virsh comm

Re: [libvirt] [PATCH] virsh: rework command parsing

2010-09-13 Thread Eric Blake
On 09/13/2010 01:41 AM, Lai Jiangshan wrote: And the usage was changed: old: virsh [options] [commands] new: virsh [options]... [commands string] virsh [options]... [ [command options]...] This needs a tweak, otherwise, executing: virsh ambiguously matches both forms. In general, you shoul

[libvirt] [PATCH] virsh: rework command parsing (was: Re: Question, how to use virDomainQemuMonitorCommand())

2010-09-13 Thread Lai Jiangshan
On 09/09/2010 09:07 PM, Daniel P. Berrange wrote: > On Thu, Sep 09, 2010 at 08:52:13AM -0400, Chris Lalancette wrote: >> On 09/09/10 - 04:52:25PM, Lai Jiangshan wrote: >>> On 09/07/2010 09:22 PM, Chris Lalancette wrote: On 09/07/10 - 04:08:13PM, Lai Jiangshan wrote: > Hi, Chris, >