Re: [libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

2016-09-15 Thread Shivaprasad G Bhat
Hi Peter, This saves few lines of code for sure :) I see the ignore_error for virXPathInt(). I see no issues. ACK Thanks a lot! -Shivaprasad On 09/15/2016 01:47 PM, Peter Krempa wrote: From: Shivaprasad G Bhat virsh maxvcpus --type kvm output is useless on PPC.

[libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

2016-09-15 Thread Peter Krempa
From: Shivaprasad G Bhat virsh maxvcpus --type kvm output is useless on PPC. Also, in commit e6806d79 we documented not rely on virConnectGetMaxVcpus output. Fix the maxvcpus to use virConnectGetDomainCapabilities now to make it useful. The call is made to use the

Re: [libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

2016-09-07 Thread Shivaprasad G Bhat
On 09/06/2016 05:56 PM, Peter Krempa wrote: On Tue, Sep 06, 2016 at 16:59:09 +0530, Shivaprasad G Bhat wrote: virsh maxvcpus --type kvm output is useless on PPC. Also, in commit e6806d79 we documented not rely on virConnectGetMaxVcpus output. Fix the maxvcpus to use

Re: [libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

2016-09-06 Thread Peter Krempa
On Tue, Sep 06, 2016 at 16:59:09 +0530, Shivaprasad G Bhat wrote: > virsh maxvcpus --type kvm output is useless on PPC. Also, in > commit e6806d79 we documented not rely on virConnectGetMaxVcpus > output. Fix the maxvcpus to use virConnectGetDomainCapabilities > now to make it useful. The call is

[libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

2016-09-06 Thread Shivaprasad G Bhat
virsh maxvcpus --type kvm output is useless on PPC. Also, in commit e6806d79 we documented not rely on virConnectGetMaxVcpus output. Fix the maxvcpus to use virConnectGetDomainCapabilities now to make it useful. The call is made to use the default emulator binary and to check for the host machine

Re: [libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

2016-07-27 Thread Peter Krempa
On Wed, Jul 27, 2016 at 18:08:29 +0530, Shivaprasad G Bhat wrote: > virsh maxvcpus --type kvm output is useless on PPC. Also, in > commit e6806d79 we documented not rely on virConnectGetMaxVcpus > output. Fix the maxvcpus to use virConnectGetDomainCapabilities > now to make it useful. The call is

[libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

2016-07-27 Thread Shivaprasad G Bhat
The following patch fixes the maxvcpus output on PPC64. Earlier I tried fixing this in kvmGetMaxVcpus() which was later decided to be document not use the virConnectGetMaxVcpus() instead use the virConnectGetDomainCapabilities api. I have not implemented the suggestedcpus as mentioned in my

[libvirt] [PATCH] virsh: use virConnectGetDomainCapabilities with maxvcpus

2016-07-27 Thread Shivaprasad G Bhat
virsh maxvcpus --type kvm output is useless on PPC. Also, in commit e6806d79 we documented not rely on virConnectGetMaxVcpus output. Fix the maxvcpus to use virConnectGetDomainCapabilities now to make it useful. The call is made to use the default qemu binary and to check for the host machine and